Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_function_app & azurerm_function_app_slot support for ip_restrictions field name, priority & action. Also added support for scm_ip_restriction field. #7447

Closed
wants to merge 2 commits into from

Conversation

SebRosander
Copy link
Contributor

@SebRosander SebRosander commented Jun 23, 2020

Fixes #7446
Fixes #7431

Same functionality as #6955 & #6705 & #6900 for app_service

…n fields name, priority & support. Also added support for scm/kudo ip-restrictions
@SebRosander SebRosander changed the title azurerm_function_app & azurerm_function_app support for ip_restrictions field name, priority & action. Also added support for scm_ip_restriction field. azurerm_function_app & azurerm_function_app_slot support for ip_restrictions field name, priority & action. Also added support for scm_ip_restriction field. Jun 24, 2020
@traeddle
Copy link

is there a plan to merge this soon?

@espenekvang
Copy link

When will this be merged?

@jackofallops
Copy link
Member

Hi @SebRosander
As discussed offline: Since I missed this PR when I was working on #7945, and I believe the changes here have been fully covered by that. With this in mind I'm going to close this and if there's functionality I've missed, I'd be happy to review a new PR for anything missed, or if you'd prefer to call it out I can get it in.

My apologies for superseding your work, albeit accidentally, I hope it doesn't put you off contributing further in future.

Thanks!

@ghost
Copy link

ghost commented Sep 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants