new resource `azurerm_stack_hci_deployment_setting` #25646

teowa · 2024-04-17T05:14:45Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Azure Doc: https://learn.microsoft.com/en-us/azure-stack/hci/deploy/deployment-azure-resource-manager-template
REST API: https://github.com/Azure/azure-rest-api-specs/blob/c4e661cdf92c8f579574008d0cd11874cc303da0/specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/stable/2024-01-01/deploymentSettings.json

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

The test can only run on Windows Administrator PowerShell, and can only run based on a VM image customized to simulate Azure VM as a HCI host, since real Azure Stack HCI needs hardware to deploy.

test env:

$env:ARM_TEST_HCI_IMAGE_ID='/subscriptions/xxxx/resourceGroups/xxxx/providers/Microsoft.Compute/galleries/xxxx/images/xxxx/versions/xxxx'
$env:ARM_TEST_HCI_LOCAL_ADMIN_USER='xxxx'
$env:ARM_TEST_HCI_LOCAL_ADMIN_USER_PASSWORD='xxxx'
$env:ARM_TEST_HCI_DOMAIN_ADMIN_USER='xxxx'
$env:ARM_TEST_HCI_DOMAIN_ADMIN_USER_PASSWORD='xxxx'
$env:ARM_TEST_HCI_DEPLOYMENT_USER='xxxx'
$env:ARM_TEST_HCI_DEPLOYMENT_USER_PASSWORD=xxxx'

My local test:

>> go test -v .\internal\services\azurestackhci -run TestAccStackHCIDeploymentSetting_basic -timeout 24h
=== RUN   TestAccStackHCIDeploymentSetting_basic
=== PAUSE TestAccStackHCIDeploymentSetting_basic
=== CONT  TestAccStackHCIDeploymentSetting_basic
--- PASS: TestAccStackHCIDeploymentSetting_basic (11582.30s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/azurestackhci 18322.985s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

new resource azurerm_stack_hci_deployment_setting [GH-00000]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

ms-zhenhua

Hi @teowa, Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

internal/services/azurestackhci/stack_hci_deployment_setting_resource.go

ms-zhenhua · 2024-04-26T00:47:44Z

internal/services/azurestackhci/stack_hci_deployment_setting_resource.go

+												},
+											},
+
+											"adapter_property_override": {


Suggested change

"adapter_property_override": {

"overridden_adapter_property": {

changed to override_adapter_property

ms-zhenhua · 2024-04-26T00:53:56Z

internal/services/azurestackhci/stack_hci_deployment_setting_resource.go

+												},
+											},
+
+											"override_adapter_property_enabled": {


please provide the default value

Suggested change

"override_adapter_property_enabled": {

"adapter_property_overriding_enabled": {

should we keep it as override_adapter_property_enabled, so it is consistent with above override_adapter_property block?

default: false added

website/docs/r/stack_hci_deployment_setting.html.markdown

ms-zhenhua · 2024-04-26T03:31:51Z

website/docs/r/stack_hci_deployment_setting.html.markdown

+
+* `infrastructure_network` - (Required) One or more `infrastructure_network` blocks as defined above. Changing this forces a new Stack HCI Deployment Setting to be created.
+
+* `naming_prefix` - (Required) Specifies the naming prefix to deploy cluster. It must be 1-8 characters long and contain only letters, numbers and hyphens Changing this forces a new Stack HCI Deployment Setting to be created.


is it the name prefix of the cluster or something else?

this is not the cluster naming prefix, it is used in naming somthing produced during deployment.

ms-zhenhua · 2024-04-26T03:33:27Z

website/docs/r/stack_hci_deployment_setting.html.markdown

+
+---
+
+A `security_setting` block supports the following:


please confirm the default values for all the sub properties

github-actions bot added documentation service/azure-stack-hci size/XL labels Apr 17, 2024

teowa marked this pull request as draft April 17, 2024 05:16

github-actions bot added waiting-response dependencies and removed waiting-response labels Apr 17, 2024

new resource stack_hci_deployment_setting

8538e65

teowa force-pushed the stackhci_deployment_setting branch from cfbabcf to 8538e65 Compare April 18, 2024 10:33

teowa mentioned this pull request Apr 22, 2024

new datasource azurerm_custom_location #25693

Open

14 tasks

ms-zhenhua suggested changes Apr 26, 2024

View reviewed changes

github-actions bot added the waiting-response label Apr 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new resource `azurerm_stack_hci_deployment_setting` #25646

new resource `azurerm_stack_hci_deployment_setting` #25646

teowa commented Apr 17, 2024 •

edited

ms-zhenhua left a comment

ms-zhenhua Apr 26, 2024

teowa May 8, 2024

ms-zhenhua Apr 26, 2024

teowa May 8, 2024

ms-zhenhua Apr 26, 2024

teowa May 8, 2024

ms-zhenhua Apr 26, 2024

	"adapter_property_override": {
	"overridden_adapter_property": {

	"override_adapter_property_enabled": {
	"adapter_property_overriding_enabled": {


		* `infrastructure_network` - (Required) One or more `infrastructure_network` blocks as defined above. Changing this forces a new Stack HCI Deployment Setting to be created.

		* `naming_prefix` - (Required) Specifies the naming prefix to deploy cluster. It must be 1-8 characters long and contain only letters, numbers and hyphens Changing this forces a new Stack HCI Deployment Setting to be created.

new resource azurerm_stack_hci_deployment_setting #25646

Are you sure you want to change the base?

new resource azurerm_stack_hci_deployment_setting #25646

Conversation

teowa commented Apr 17, 2024 • edited

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

Related Issue(s)

ms-zhenhua left a comment

Choose a reason for hiding this comment

ms-zhenhua Apr 26, 2024

Choose a reason for hiding this comment

teowa May 8, 2024

Choose a reason for hiding this comment

ms-zhenhua Apr 26, 2024

Choose a reason for hiding this comment

teowa May 8, 2024

Choose a reason for hiding this comment

ms-zhenhua Apr 26, 2024

Choose a reason for hiding this comment

teowa May 8, 2024

Choose a reason for hiding this comment

ms-zhenhua Apr 26, 2024

Choose a reason for hiding this comment

new resource `azurerm_stack_hci_deployment_setting` #25646

new resource `azurerm_stack_hci_deployment_setting` #25646

teowa commented Apr 17, 2024 •

edited