azurerm_machine_learning_workspace - Add support for serverless_compute

[xuzhang3]

Add support for serverless_compute.custom_subnet_id, serverless_compute.no_public_ip_enabled`

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #0000

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks @xuzhang3. Please take a look at the comments so far, once they've been fixed we can continue the review.

[stephybun]

This could be shortened to

Suggested change

	"custom_subnet_id": {
	"subnet_id": {

[stephybun]

Prefixing a boolean with no_ violates the naming standard we use for bools. This needs to become

Suggested change

	"no_public_ip_enabled": {
	"public_ip_enabled": {

[xuzhang3]

Can we keep this to no_public_ip_enabled? If renamed to public_ip_enabled we need to reverse the value before send to service or set to state. Also service will return the validation error such like: ValidationError: Not supported to update ServerlessComputeNoPublicIP from false to true when public network access is enabled and this validation may changed in the future. Users may confused by the error message because the name is not same to public_ip_enabled

[stephybun]

We have many instances where we flip the boolean values around in the provider to conform to the standards the provider has. In addition that error message indicates a limitation on when public_ip_enabled can be updated which means we should probably have some validation around this in the Create and Update methods and can thus return our own error message instead of relying on the API to error.

Given the above this property still needs to become public_ip_enabled.

[xuzhang3]

ok will update it

[katbyte]

we nhave a test failure

------- Stdout: -------
=== RUN   TestAccMachineLearningWorkspace_serverlessCompute
=== PAUSE TestAccMachineLearningWorkspace_serverlessCompute
=== CONT  TestAccMachineLearningWorkspace_serverlessCompute
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        
        Error:  Not supported to set `public_ip_enabled` to `false` without `subnet_id` when `public_network_access_enabled` is `false`
        
          with azurerm_machine_learning_workspace.test,
          on terraform_plugin_test.tf line 86, in resource "azurerm_machine_learning_workspace" "test":
          86: resource "azurerm_machine_learning_workspace" "test" {
        
--- FAIL: TestAccMachineLearningWorkspace_serverlessCompute (342.14s)
FAIL