Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_log_analytics_cluster: update API version to 2022-10-01 #25686

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Apr 22, 2024

draft to run acctests on TC

update the API version of operationalinsights/clusters from 2020-08-01 to 2022-10-01

Community Note

  • Please vote on this PR by adding a πŸ‘ reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: β€œresource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
│❯❯ tftest loganalytics TestAccLogAnalyticsCluster_basic                                                          β”‚
β”‚=== RUN   TestAccLogAnalyticsCluster_basic                                                                       β”‚
β”‚=== PAUSE TestAccLogAnalyticsCluster_basic                                                                       β”‚
β”‚=== CONT  TestAccLogAnalyticsCluster_basic                                                                       β”‚
β”‚--- PASS: TestAccLogAnalyticsCluster_basic (2857.30s)                                                            β”‚
β”‚PASS                                                                                                             β”‚
β”‚ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/loganalytics  2859.395s  

❯❯ tftest loganalytics TestAccLogAnalyticsCluster_resize
=== RUN   TestAccLogAnalyticsCluster_resize
=== PAUSE TestAccLogAnalyticsCluster_resize
=== CONT  TestAccLogAnalyticsCluster_resize
--- PASS: TestAccLogAnalyticsCluster_resize (715.91s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/loganalytics  718.072s

❯❯ tftest loganalytics TestAccLogAnalyticsCluster_requiresImport
=== RUN   TestAccLogAnalyticsCluster_requiresImport
=== PAUSE TestAccLogAnalyticsCluster_requiresImport
=== CONT  TestAccLogAnalyticsCluster_requiresImport
--- PASS: TestAccLogAnalyticsCluster_requiresImport (2126.68s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/loganalytics  2128.792s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

azurerm_log_analytics_cluster: update API version to 2022-10-01 [GH-25686]

Related Issue(s)

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ“¦

@katbyte katbyte merged commit 90c121c into hashicorp:main May 6, 2024
29 checks passed
@github-actions github-actions bot added this to the v3.103.0 milestone May 6, 2024
katbyte added a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants