Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_flux_configuration - added postBuild and wait properties to kustomization block #25695

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jayctran
Copy link

@jayctran jayctran commented Apr 22, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Every time I tried to run the acceptance tests I hit this issue and couldn't get past it.
image
image

Got this working in the project I needed this for:
image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #24081

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure:

------- Stdout: -------
=== RUN   TestAccKubernetesFluxConfiguration_kustomizationPostBuild
=== PAUSE TestAccKubernetesFluxConfiguration_kustomizationPostBuild
=== CONT  TestAccKubernetesFluxConfiguration_kustomizationPostBuild
    testcase.go:113: Step 1/2 error: Error running pre-apply refresh: exit status 1
        
        Error: Missing key/value separator
        
          on terraform_plugin_test.tf line 80, in resource "azurerm_kubernetes_flux_configuration" "test":
          75:     postBuild = {
          76:       substitute = {
          77:         "key" = "value",
          78:         "key2" = "value2"
          79:       }
          80:       substituteFrom {
        
        Expected an equals sign ("=") to mark the beginning of the attribute value.
    testing_new.go:79: Error retrieving state, there may be dangling resources: exit status 1
        
        Error: Missing key/value separator
        
          on terraform_plugin_test.tf line 80, in resource "azurerm_kubernetes_flux_configuration" "test":
          75:     postBuild = {
          76:       substitute = {
          77:         "key" = "value",
          78:         "key2" = "value2"
          79:       }
          80:       substituteFrom {
        
        Expected an equals sign ("=") to mark the beginning of the attribute value.
--- FAIL: TestAccKubernetesFluxConfiguration_kustomizationPostBuild (2.04s)
FAIL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for postBuild substitution in flux_configuration
3 participants