azurerm_storage_share_file
- Post hex decode then base64 encode the value of content_md5
, to align with Azure expectation
#25715
+14
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This PR changes added post processs (i.e. hex decode then base64 encode the value) for the
content_md5
, to align with Azure expectation.The current implementation of the
content_md5
(i.e. plainly set the value to API) will fail the post md5 check when users try to download the file viaazcopy
, e.g.Though this is technically a breaking change (for users who manually do the conversion before setting it in TF config), I still submit this change for two reasons:
azurerm_storage_blob
resource has the same behavior that post-processes thecontent_md5
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
By uploading the
CHANGELOG.md
file at this branch:before (uploaded as
test
)Failed to download the file as it failed the md5sum check:
after (uploaded as
test2
)It is donwloaded successfully:
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_storage_share_file
- Post hex decode then base64 encode the value ofcontent_md5
, to align with Azure expectation [GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #25704
Note
If this PR changes meaningfully during the course of review please update the title and description as required.