compute - migrate legacy compute resources to hashicorp/go-azure-sdk
#25723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephybun
added
service/virtual-machine
service/vmss
jackofallops
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Thanks @stephybun - Just one (possibly over paranoid) thing to check below, otherwise LGTM 馃
| return fmt.Errorf("Failed long polling for the stop of virtual machine %q: %+v", resourceGroup, err) | ||
| ctx2, cancel := context.WithTimeout(ctx, 10*time.Minute) | ||
| defer cancel() | ||
| if err := client.Compute.VirtualMachinesClient.DeallocateThenPoll(ctx2, *id, virtualmachines.DefaultDeallocateOperationOptions()); err != nil { |
There was a problem hiding this comment.
Just to be completely sure, is the default option value (nil bool) treated the same as false here? We sent an explicit false previously, so need to be careful the behaviour is the same after this change.
There was a problem hiding this comment.
updated to send a false like we were previously doing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This updates the legacy compute resources to use
hashicorp/go-azure-sdkand removes the last references to the legacy Azure Track1 SDK.Testing
Failing deprecated usage check can be ignored since the existing behaviour of the resource should be preserved
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
compute- update legacy compute resources to usehashicorp/go-azure-sdk[GH-00000]Note
If this PR changes meaningfully during the course of review please update the title and description as required.