New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0
- removes several instances of ConfigModeAttr
from automation
, batch
, containerinstance
#25732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort in all the tests since it will become Required in 4.0
github-actions
bot
added
documentation
service/key-vault
Key Vault
service/automation
service/batch
size/XL
waiting-response
labels
Apr 24, 2024
stephybun
commented
Apr 25, 2024
@@ -434,6 +434,7 @@ func TestDataSourcesWithAnEncryptionBlockBehaveConsistently(t *testing.T) { | |||
// TODO: 4.0 - work through this list | |||
dataSourcesWhichNeedToBeAddressed := map[string]struct{}{ | |||
"azurerm_app_configuration": {}, | |||
"azurerm_batch_account": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added here until we know more about what this schema check is trying to prevent
stephybun
force-pushed
the
f/remote-config-mode-attr
branch
from
April 25, 2024 12:42
4dce444
to
65edff6
Compare
jackofallops
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stephybun - LGTM 🦖
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
azurerm_key_vault
azurerm_automation_runbook
ConfigModeAttr
fromjob_schedule
azurerm_automation_webhook
ConfigModeAttr
fromuri
azurerm_batch_account
ConfigModeAttr
fromencryption
in data sourceazurerm_batch_pool
ConfigModeAttr
fromcontainer_registries
inazurerm_batch_pool
azurerm_container_group
ConfigModeAttr
fromexposed_port
gpu
andgpu_limit
blocksazurerm_container_registry
ConfigModeAttr
fromretention_policy
by replacing the property withretention_policy_in_days
in 4.0ConfigModeAttr
fromtrust_policy
by replacing the property withtrust_policy_enabled
in 4.0ConfigModeAttr
fromencryption
inazurerm_container_group
encryption.enabled
,retention_policy
,trust_policy
inazurerm_container_group
Computed
onnetwork_rule_set
in 4.0azurerm_container_group
and updates the update function to used.HasChange
Testing
Failed tests are on main
Note
If this PR changes meaningfully during the course of review please update the title and description as required.