Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0- removes several instances of ConfigModeAttr from automation, batch, containerinstance #25732

Merged
merged 10 commits into from Apr 29, 2024

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Apr 24, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

azurerm_key_vault

  • Fixes a 4.0 crash

azurerm_automation_runbook

  • Removes ConfigModeAttr from job_schedule

azurerm_automation_webhook

  • Removes ConfigModeAttr from uri

azurerm_batch_account

  • Removes ConfigModeAttr from encryption in data source

azurerm_batch_pool

  • Removes ConfigModeAttr from container_registries in azurerm_batch_pool

azurerm_container_group

  • Removes ConfigModeAttr from exposed_port
  • Deprecated gpu and gpu_limit blocks
  • Update SKU and test check used for gpu tests
  • Updates various checks and configs to fix existing tests
  • Increases create timeout for failing gpu tests

azurerm_container_registry

  • Removes ConfigModeAttr from retention_policy by replacing the property with retention_policy_in_days in 4.0
  • Removes ConfigModeAttr from trust_policy by replacing the property with trust_policy_enabled in 4.0
  • Removes ConfigModeAttr from encryption in azurerm_container_group
  • Deprecates encryption.enabled, retention_policy, trust_policy in azurerm_container_group
  • Removes Computed on network_rule_set in 4.0
  • Cleans up some of the tests for azurerm_container_group and updates the update function to use d.HasChange

Testing

image

image

image

Failed tests are on main

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@@ -434,6 +434,7 @@ func TestDataSourcesWithAnEncryptionBlockBehaveConsistently(t *testing.T) {
// TODO: 4.0 - work through this list
dataSourcesWhichNeedToBeAddressed := map[string]struct{}{
"azurerm_app_configuration": {},
"azurerm_batch_account": {},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added here until we know more about what this schema check is trying to prevent

@stephybun stephybun marked this pull request as ready for review April 25, 2024 09:49
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - LGTM 🦖

@stephybun stephybun merged commit a585719 into main Apr 29, 2024
33 checks passed
@stephybun stephybun deleted the f/remote-config-mode-attr branch April 29, 2024 12:04
@github-actions github-actions bot added this to the v3.102.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants