azurerm_container_app - Remove 'cannot remove secrets' check

[cgraf-spiria]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Fix for issue #24945
Removing a check that was added to print an error when a container app secret is removed.
This check is no longer needed since the underlying issue in azure-container-apps was fixed.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

I tested locally by updating a container app's secrets. Adding and removing one or multiple secrets worked.
Since I'm removing code, I didn't include additional tests/coverage.

Change Log

• azurerm_container_app - Remove 'cannot remove secrets' check

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #24945

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[jackofallops]

Hi @cgraf-spiria - Can you add a tests to prove the underlying fix on the service actually works for a removing a secret, and another that checks we get the correct error behaviours described in the issue linked? Once those are added we can continue review.

Thanks!

[cgraf-spiria]

My bad, didn't quite understand how testing worked. First time contributing to this project :)
I re-added the tests for secret change name and secret delete. Hope this ok, or should I combine them into a single test?

[katbyte]

Thanks @cgraf-spiria - LGTM 📚