Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore azurerm_nginx_configuration resource and data source #25773

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

valyria257
Copy link

Reverts #24276

There are a couple of things here:

  • The default configuration/import error issue was resolved. See changelog from March 13, 2024
  • This is a breaking change from a product use-case perspective as it breaks our HTTPS use-case where in the workflow is:
    1. Create deployment.
    2. Create certificate.
    3. Create configuration.

With configuration now being inline, the use workflow breaks as 1 and 3 cannot be separated.

  • certificates should also not be inline since different roles may mange deployments, certificates, and configurations separately

To fix this, the change to remove the azurerm_nginx_configuration is reverted, and the field that was added to replace it is deprecated.

"tags": commonschema.Tags(),
}

if !features.FourPointOhBeta() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this how features are deprecated in TF? I have not looked at this function but I vaguely remember that this was for breaking changes when the provider gets a 4.0 bumped.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! I got that from this contributing guide: https://github.com/hashicorp/terraform-provider-azurerm/blob/main/contributing/topics/guide-new-fields-to-resource.md#renaming-and-deprecating-a-property, but could use some direction here if there's a different way.

@valyria257 valyria257 marked this pull request as ready for review April 30, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants