Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account: add permanent_delete_enabled #25778

Merged

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Apr 27, 2024

Description

Add permanent_delete_enabled to blob properties delete retention policy.

Took over #22109

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

image

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_storage_account - Support for permanent_delete_enabled property in blobs delete retention policy.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #21830

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Add `permanent_delete_enabled` to blob properties delete retention
policy.

Took over hashicorp#22109

Fixes hashicorp#21830
@github-actions github-actions bot added size/M and removed size/S labels Apr 27, 2024
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛈️

@katbyte katbyte merged commit 96b6c99 into hashicorp:main May 6, 2024
33 checks passed
@github-actions github-actions bot added this to the v3.103.0 milestone May 6, 2024
katbyte added a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add allow_permanent_delete property to delete_retention_policy (azurerm_storage_account.blob_properties)
2 participants