New Resource: `azurerm_data_protection_backup_policy_postgresql_flexible_server` #26024

neil-yechenwei · 2024-05-20T03:04:04Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support Data Protection Backup Policy for Postgresql FS.

API Reference: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2024-04-01
Overview: https://learn.microsoft.com/en-us/azure/postgresql/flexible-server/concepts-backup-restore#long-term-retention-preview

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
I have written new tests for my resource or datasource changes & updated any relevent documentation.
I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
(For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccDataProtectionBackupPolicyPostgreSQLFlexibleServer_requiresImport (304.81s)
--- PASS: TestAccDataProtectionBackupPolicyPostgreSQLFlexibleServer_basic (317.77s)
--- PASS: TestAccDataProtectionBackupPolicyPostgreSQLFlexibleServer_complete (302.13s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Resource: azurerm_data_protection_backup_policy_postgresql_flexible_server

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…le_server

…ppolicypostgresqlfs

ms-zhenhua

Hi @neil-yechenwei,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

...services/dataprotection/data_protection_backup_policy_postgresql_flexible_server_resource.go

...ces/dataprotection/data_protection_backup_policy_postgresql_flexible_server_resource_test.go

website/docs/r/data_protection_backup_policy_postgresql_flexible_server.html.markdown

neil-yechenwei · 2024-05-27T06:01:35Z

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look.

neil-yechenwei · 2024-05-28T10:30:08Z

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look. Below is the latest test result that I just now triggered.

ms-zhenhua · 2024-05-29T03:39:05Z

Hi @neil-yechenwei, thank you for your updates. LGTM~

katbyte

LGTM ⛈️

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.104.2" to "3.107.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.107.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.107.0
FEATURES:

* **New Resource:** `azurerm_data_protection_backup_policy_postgresql_flexible_server` ([#26024](https://github.com/hashicorp/terraform-provider-azurerm/issues/26024))

ENHANCEMENTS:

* dependencies: updating to `v0.20240604.1114748` of `github.com/hashicorp/go-azure-sdk` ([#26216](https://github.com/hashicorp/terraform-provider-azurerm/issues/26216))
* `advisor`: update API version to `2023-01-01` ([#26205](https://github.com/hashicorp/terraform-provider-azurerm/issues/26205))
* `keyvault`: handling the Resources API returning Key Vaults that have been deleted when populating the cache ([#26199](https://github.com/hashicorp/terraform-provider-azurerm/issues/26199))
* `machinelearning`: update API version to `2024-04-01` ([#26168](https://github.com/hashicorp/terraform-provider-azurerm/issues/26168))
* `network/privatelinkservices` - update to use `hashicorp/go-azure-sdk` ([#26212](https://github.com/hashicorp/terraform-provider-azurerm/issues/26212))
* `network/serviceendpointpolicies` - update to use `hashicorp/go-azure-sdk` ([#26196](https://github.com/hashicorp/terraform-provider-azurerm/issues/26196))
* `network/virtualnetworks` - update to use `hashicorp/go-azure-sdk` ([#26217](https://github.com/hashicorp/terraform-provider-azurerm/issues/26217))
* `network/virtualwans`: update route resources to use `hashicorp/go-azure-sdk` ([#26189](https://github.com/hashicorp/terraform-provider-azurerm/issues/26189))
* `azurerm_container_app_job` - support for the `key_vault_secret_id` and `identity` properties in the `secret` block ([#25969](https://github.com/hashicorp/terraform-provider-azurerm/issues/25969))
* `azurerm_kubernetes_cluster` - support forthe `dns_zone_ids` popperty in the `web_app_routing` block ([#26117](https://github.com/hashicorp/terraform-provider-azurerm/issues/26117))
* `azurerm_notification_hub_authorization_rule` - support for the `primary_connection_string` and `secondary_connection_string` properties ([#26188](https://github.com/hashicorp/terraform-provider-azurerm/issues/26188))
* `azurerm_subnet` - support for the `default_outbound_access_enabled` property ([#25259](https://github.com/hashicorp/terraform-provider-azurerm/issues/25259))

BUG FIXES:

* `azurerm_api_management_named_value` - will now enforce setting the `secret` property when setting the `value_from_key_vault` property ([#26150](https://github.com/hashicorp/terraform-provider-azurerm/issues/26150))
* `azurerm_storage_sync_server_endpoint` - improve pooling to work around api inconsistencies ([#26204](https://github.com/hashicorp/terraform-provider-azurerm/issues/26204))
* `azurerm_virtual_network` - split create and update function to fix lifecycle - ignore ([#26246](https://github.com/hashicorp/terraform-provider-azurerm/issues/26246))
* `azurerm_vpn_server_configuration` - split create and update function to fix lifecycle - ignore ([#26175](https://github.com/hashicorp/terraform-provider-azurerm/issues/26175))
* `azurerm_vpn_server_configuration_policy_group` - split create and update function to fix lifecycle - ignore ([#26207](https://github.com/hashicorp/terraform-provider-azurerm/issues/26207))
* `azurerm_vpn_site` - split create and update function to fix lifecycle - ignore changes ([#26163](https://github.com/hashicorp/terraform-provider-azurerm/issues/26163))

DEPRECATIONS:

* `azurerm_kubernetes_cluster` - the property `dns_zone_id` has been superseded by the property `dns_zone_ids` in the `web_app_routing` block ([#26117](https://github.com/hashicorp/terraform-provider-azurerm/issues/26117))
* `azurerm_nginx_deployment` - the block `configuration` has been deprecated and superseded by the resource `azurerm_nginx_configuration` ([#25773](https://github.com/hashicorp/terraform-provider-azurerm/issues/25773))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/229/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> --------- Signed-off-by: Damien Duportal <damien.duportal@gmail.com> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com> Co-authored-by: Damien Duportal <damien.duportal@gmail.com>

neil-yechenwei added 11 commits December 7, 2023 17:09

New Resource: azurerm_data_protection_backup_policy_postgresql_flexib…

00760bc

…le_server

Merge remote-tracking branch 'upstream/main' into dataprotectionbacku…

22d29c0

…ppolicypostgresqlfs

update code

4982a60

update resource

19e5c2a

update the resource

2a00b64

refine resource

c4fa6cb

use valut id

f9de9aa

use commonschema for vault it

4b99c5f

define data_store_type in the schema

ba5335b

remove data_store_type for AzureBackupRule

2fecc00

Update testcase

14336f3

neil-yechenwei marked this pull request as draft May 20, 2024 03:04

github-actions bot added documentation service/data-protection size/XL waiting-response labels May 20, 2024

update format

2f93844

github-actions bot removed the waiting-response label May 20, 2024

ms-zhenhua suggested changes May 24, 2024

View reviewed changes

github-actions bot added the waiting-response label May 24, 2024

update code per comment

e67756a

github-actions bot removed the waiting-response label May 27, 2024

neil-yechenwei requested a review from ms-zhenhua May 27, 2024 06:01

github-actions bot added the waiting-response label May 28, 2024

add empty check

fa9285c

github-actions bot removed the waiting-response label May 28, 2024

update to int64

b8161e8

ms-zhenhua approved these changes May 29, 2024

View reviewed changes

neil-yechenwei marked this pull request as ready for review May 29, 2024 03:55

katbyte approved these changes Jun 4, 2024

View reviewed changes

katbyte merged commit 5d01ac8 into hashicorp:main Jun 4, 2024
37 checks passed

github-actions bot added this to the v3.107.0 milestone Jun 4, 2024

katbyte added a commit that referenced this pull request Jun 4, 2024

Update CHANGELOG.md #26024

cc15664

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_data_protection_backup_policy_postgresql_flexible_server` #26024

New Resource: `azurerm_data_protection_backup_policy_postgresql_flexible_server` #26024

neil-yechenwei commented May 20, 2024 •

edited

ms-zhenhua left a comment

neil-yechenwei commented May 27, 2024

neil-yechenwei commented May 28, 2024 •

edited

ms-zhenhua commented May 29, 2024

katbyte left a comment

New Resource: azurerm_data_protection_backup_policy_postgresql_flexible_server #26024

New Resource: azurerm_data_protection_backup_policy_postgresql_flexible_server #26024

Conversation

neil-yechenwei commented May 20, 2024 • edited

Community Note

Description

PR Checklist

Changes to existing Resource / Data Source

Testing

Change Log

ms-zhenhua left a comment

Choose a reason for hiding this comment

neil-yechenwei commented May 27, 2024

neil-yechenwei commented May 28, 2024 • edited

ms-zhenhua commented May 29, 2024

katbyte left a comment

Choose a reason for hiding this comment

New Resource: `azurerm_data_protection_backup_policy_postgresql_flexible_server` #26024

New Resource: `azurerm_data_protection_backup_policy_postgresql_flexible_server` #26024

neil-yechenwei commented May 20, 2024 •

edited

neil-yechenwei commented May 28, 2024 •

edited