Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault - can now be created without subscription level permissions (fixes #6059) #6260

Merged
merged 8 commits into from Apr 29, 2020

Commits on Mar 24, 2020

  1. Issue hashicorp#6059 - subscription rights for key_vault

    This commit fixes issue hashicorp#6509, in which some subscription level
    rights are required in order to create a key_vault. This occurred
    due to the provider always looking for a soft deleted key vault
    prior to checking whether the feature
    KeyVault.RecoverSoftDeletedKeyVaults was set to true. Thus event
    setting the value to false did not stop it searching for the soft
    deletions.
    
    The rights it was requiring were to perform action
    'Microsoft.KeyVault/locations/deletedVaults/read' over scope
    '/subscriptions/xxxxxx'
    Jawvig committed Mar 24, 2020
    Copy the full SHA
    d2b0234 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Key Vault soft delete no recovery fix

    This commit fixes hashicorp#6509 by building on the previous commit to:
    1) Remove the (now redundant) error message returned when there's
       a soft deleted vault of the same name but the user doesn't want
       to recover it. This is already covered by an error returned by
       Azure.
    2) Fix the acceptance test to look for the error message Azure
       returns in this instance, rather than the text in the removed
       error.
    3) Fixes the test to add a secret to the soft deleted vault, as
       Azure will otherwise silently recover the vault anyway (even if
       the mode is not 'recover') in this case.
    4) Fixes the test so that it doesn't purge the vault on destroy.
    Jawvig committed Mar 25, 2020
    Copy the full SHA
    1fe664f View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    a5be882 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    1729afb View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Copy the full SHA
    6c29ab9 View commit details
    Browse the repository at this point in the history
  2. change to hashicorp#6693

    katbyte committed Apr 29, 2020
    Copy the full SHA
    58a7524 View commit details
    Browse the repository at this point in the history
  3. add in helper

    katbyte committed Apr 29, 2020
    Copy the full SHA
    2dd12af View commit details
    Browse the repository at this point in the history
  4. revert test

    katbyte committed Apr 29, 2020
    Copy the full SHA
    fea9da3 View commit details
    Browse the repository at this point in the history