Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Keyvault soft delete recovery to be attempted when Read permissions are not allowed at Subscription #6693

Closed
wants to merge 2 commits into from

Conversation

jackofallops
Copy link
Member

This change permits Terraform to attempt to recover a soft-deleted keyvault when the Principal it is is being run with lacks read permissions for keyvaults at the Subscription level and recover_soft_deleted_key_vaults is set to true.

fixes #6059

@jackofallops jackofallops added this to the v2.8.0 milestone Apr 29, 2020
@jackofallops jackofallops requested a review from a team April 29, 2020 16:14
@ghost ghost added the size/XS label Apr 29, 2020
katbyte added a commit to Jawvig/terraform-provider-azurerm that referenced this pull request Apr 29, 2020
@katbyte
Copy link
Collaborator

katbyte commented Apr 29, 2020

closing in favour of #6260

@katbyte katbyte closed this Apr 29, 2020
@jackofallops jackofallops deleted the b/kv-softdel branch April 30, 2020 06:41
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.8.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzureRm V2: Cannot create keyVault without Subscription Level Permissions
2 participants