Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_api_management_subscription get Primary/Secondary Key #6938

Merged
merged 11 commits into from May 20, 2020
Merged

azurerm_api_management_subscription get Primary/Secondary Key #6938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f21db0a
update
Apr 30, 2020
65876d5
test pass
May 6, 2020
3d5dab2
Merge branch 'master' of https://github.com/terraform-providers/terra…
May 6, 2020
3bbb42c
remove ignore changes
May 6, 2020
00a167e
r1
May 7, 2020
8ef717c
Merge branch 'master' of https://github.com/terraform-providers/terra…
May 7, 2020
cc8e8f8
merge
May 11, 2020
a07f285
Merge branch 'master' of https://github.com/terraform-providers/terra…
May 12, 2020
5c758d5
Merge branch 'master' of https://github.com/terraform-providers/terra…
May 13, 2020
d92b185
apim subs key
May 13, 2020
39b0200
update
May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions azurerm/internal/services/apimanagement/api_management_subscription_resource.go
View file
Open in desktop
Expand Up @@ -187,13 +187,19 @@ func resourceArmApiManagementSubscriptionRead(d *schema.ResourceData, meta inter

if props := resp.SubscriptionContractProperties; props != nil {
d.Set("display_name", props.DisplayName)
d.Set("primary_key", props.PrimaryKey)
d.Set("secondary_key", props.SecondaryKey)
d.Set("state", string(props.State))
d.Set("product_id", props.Scope)
d.Set("user_id", props.OwnerID)
}

// Primary and secondary keys must be got from this additional api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this documented as a breaking change from Microsoft? Just curious how you figured this out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service team comment it in swagger

keyResp, err := client.ListSecrets(ctx, resourceGroup, serviceName, subscriptionId)
if err != nil {
return fmt.Errorf("listing Subscription %q Primary and Secondary Keys (API Management Service %q / Resource Group %q): %+v", subscriptionId, serviceName, resourceGroup, err)
}
d.Set("primary_key", keyResp.PrimaryKey)
d.Set("secondary_key", keyResp.SecondaryKey)

return nil
}

Expand Down
8 changes: 8 additions & 0 deletions azurerm/internal/services/apimanagement/tests/api_management_subscription_resource_test.go
View file
Open in desktop
Expand Up @@ -24,6 +24,8 @@ func TestAccAzureRMAPIManagementSubscription_basic(t *testing.T) {
Check: resource.ComposeTestCheckFunc(
testCheckAzureRMAPIManagementSubscriptionExists(data.ResourceName),
resource.TestCheckResourceAttrSet(data.ResourceName, "subscription_id"),
resource.TestCheckResourceAttrSet(data.ResourceName, "primary_key"),
resource.TestCheckResourceAttrSet(data.ResourceName, "secondary_key"),
),
},
data.ImportStep(),
Expand All @@ -44,6 +46,8 @@ func TestAccAzureRMAPIManagementSubscription_requiresImport(t *testing.T) {
Check: resource.ComposeTestCheckFunc(
testCheckAzureRMAPIManagementSubscriptionExists(data.ResourceName),
resource.TestCheckResourceAttrSet(data.ResourceName, "subscription_id"),
resource.TestCheckResourceAttrSet(data.ResourceName, "primary_key"),
resource.TestCheckResourceAttrSet(data.ResourceName, "secondary_key"),
),
},
data.RequiresImportErrorStep(testAccAzureRMAPIManagementSubscription_requiresImport),
Expand All @@ -65,6 +69,8 @@ func TestAccAzureRMAPIManagementSubscription_update(t *testing.T) {
testCheckAzureRMAPIManagementSubscriptionExists(data.ResourceName),
resource.TestCheckResourceAttr(data.ResourceName, "state", "submitted"),
resource.TestCheckResourceAttrSet(data.ResourceName, "subscription_id"),
resource.TestCheckResourceAttrSet(data.ResourceName, "primary_key"),
resource.TestCheckResourceAttrSet(data.ResourceName, "secondary_key"),
),
},
{
Expand Down Expand Up @@ -106,6 +112,8 @@ func TestAccAzureRMAPIManagementSubscription_complete(t *testing.T) {
testCheckAzureRMAPIManagementSubscriptionExists(data.ResourceName),
resource.TestCheckResourceAttr(data.ResourceName, "state", "active"),
resource.TestCheckResourceAttrSet(data.ResourceName, "subscription_id"),
resource.TestCheckResourceAttrSet(data.ResourceName, "primary_key"),
resource.TestCheckResourceAttrSet(data.ResourceName, "secondary_key"),
),
},
data.ImportStep(),
Expand Down