Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/signalr - adds support for EnableMessagingLogs feature #7094

Merged
merged 3 commits into from Jun 1, 2020
Merged

r/signalr - adds support for EnableMessagingLogs feature #7094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6e6f31
Adds `EnableMessagingLogs` to validation
tracypholmes May 26, 2020
ac83a97
Adds updated features value to docs
tracypholmes May 26, 2020
f146e77
Updates w/actual string & comment
tracypholmes May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions azurerm/internal/services/signalr/resource_arm_signalr_service.go
View file
Open in desktop
Expand Up @@ -85,6 +85,9 @@ func resourceArmSignalRService() *schema.Resource {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{
// Looks like the default has changed, ours will need to be updated in AzureRM 3.0.
// issue has been created https://github.com/Azure/azure-sdk-for-go/issues/9619
"EnableMessagingLogs",
string(signalr.EnableConnectivityLogs),
string(signalr.ServiceMode),
}, false),
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/signalr_service.html.markdown
View file
Open in desktop
Expand Up @@ -67,7 +67,7 @@ A `cors` block supports the following:

A `features` block supports the following:

* `flag` - (Required) The kind of Feature. Possible values are `EnableConnectivityLogs` and `ServiceMode`.
* `flag` - (Required) The kind of Feature. Possible values are `EnableConnectivityLogs`, `EnableMessagingLogs`, and `ServiceMode`.

* `value` - (Required) A value of a feature flag. Possible values are `Classic`, `Default` and `Serverless`.

Expand Down