Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Advanced_filter to eventgrid event subscription resource #7102

Closed
wants to merge 4 commits into from

Conversation

VaijanathB
Copy link
Contributor

This changeset adds ability to add advanced_filters which were missing in terraform and present in the go_sdk. Filters like StringContains, BoolEquals, NumberIn, NumberNotIn were missing and are required by advanced users of eventgrid.

@ghost ghost added the size/XL label May 27, 2020
@tombuildsstuff
Copy link
Member

hey @VaijanathB

Thanks for opening this PR :)

Taking a look through this appears to be a duplicate of #6861 - as such whilst I'd like to thank you for this contribution I hope you don't mind but I'm going close this PR in favour of #6861.

Thanks!

@VaijanathB
Copy link
Contributor Author

@tombuildsstuff, Great. I had not seen that PR. I still feel that doing it like my way would be simpler and closer to what go_sdk is doing. Anyways, if you prefer 6861 then I am fine with it.

Thanks,
VaijanathB

@ghost
Copy link

ghost commented Jun 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants