r/nat_gateway_public_ip_association: using a custom ID / support for delta updates in azurerm_nat_gateway
#7106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a custom ID for the `azurerm_nat_gateway_public_ip_address_association` resource. This allows us to determine /which/ Public IP Address is currently assigned to the NAT Gateway since there can be multiple.
…pdate of the nat gateway
ghost
added
|
Tests pass:
|
|
This has been released in version 2.12.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.12.0"
}
# ... other configuration ... |
pbrit
pushed a commit
to pbrit/terraform-provider-azurerm
that referenced
this pull request
May 31, 2020
…delta updates in `azurerm_nat_gateway` (hashicorp#7106) This PR fixes some issues spotted in hashicorp#6450 - namely: Using a custom Resource ID for the azurerm_nat_gateway_public_ip_association resource - which includes the Public IP Address ID so that we can determine which Public IP Address is being referenced Supporting delta updates in the azurerm_nat_gateway resource
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues spotted in #6450 - namely:
azurerm_nat_gateway_public_ip_associationresource - which includes the Public IP Address ID so that we can determine which Public IP Address is being referencedazurerm_nat_gatewayresource