Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_hdinsight_*_cluster - fix broken updaten due to api not allowing cluster to be disabled #7111

Merged
merged 13 commits into from Jun 29, 2020

Conversation

kosinsky
Copy link
Contributor

Fixes issues like #7067

HDInisght doesn't support disabling Gateway/Ambari for Linux clusters and only Linux clusters supported.
Making gateway.enabled property always equal true.
Also using API call to update Gateway settings (changing password)

Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

azurerm/helpers/azure/hdinsight.go Outdated Show resolved Hide resolved
azurerm/helpers/azure/hdinsight.go Outdated Show resolved Hide resolved
kosinsky and others added 2 commits June 9, 2020 08:14
@kosinsky
Copy link
Contributor Author

@magodo, I did requested changes. Could you take another look?

@magodo
Copy link
Collaborator

magodo commented Jun 11, 2020

@kosinsky Thanks for updating the code!
@katbyte Would you please take a look at this PR? It looks good to me. Besides, there is another PR (#7272 ) that is related with #7067 you might also want to review.

@katbyte katbyte changed the title Support updating HDInsight gateway azurerm_hdinsight_*_cluster - fix broken updaten due to api not allowing cluster to be disabled Jun 29, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kosinsky! LGTM aside from some documentation tweaks i'm going to make now 🚀

website/docs/r/hdinsight_hadoop_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/hdinsight_hbase_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/hdinsight_kafka_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/hdinsight_ml_services_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/hdinsight_rserver_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/hdinsight_spark_cluster.html.markdown Outdated Show resolved Hide resolved
website/docs/r/hdinsight_storm_cluster.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte added this to the 2.13.0 milestone Jun 29, 2020
@katbyte katbyte modified the milestones: 2.13.0, v2.17.0 Jun 29, 2020
@katbyte katbyte merged commit d2b314d into hashicorp:master Jun 29, 2020
katbyte added a commit that referenced this pull request Jun 29, 2020
@ghost
Copy link

ghost commented Jul 3, 2020

This has been released in version 2.17.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.17.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants