Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthorizationRules -> authorizationRules #7147

Closed
wants to merge 1 commit into from

Conversation

markusleh
Copy link
Contributor

According to the latest API version for Microsoft.EventHub namespaces/authorizationRules templates, the correct path for authorization rules is authorizationRules since API version 2017-04-01.
See https://docs.microsoft.com/en-us/azure/templates/Microsoft.EventHub/namespaces/authorizationrules

Currently deployment fails when getting the authorization rule after creating a new authorization rule or fetching old one.

According to the latest API version for Microsoft.EventHub namespaces/authorizationRules templates, the correct path for authorization rules is `authorizationRules` since API version 2017-04-01.
See https://docs.microsoft.com/en-us/azure/templates/Microsoft.EventHub/namespaces/authorizationrules

Currently deployment fails when getting the authorization rule after creating a new authorization rule or fetching old one.
@tombuildsstuff
Copy link
Member

hey @markusleh

Thanks for this PR - apologies for the delayed response here!

Taking a look through here, whilst this approach will work for newly created resources - unfortunately this approach won't work when an existing resource has been created using an older API version (where this has the older ID format authorizationRules.

One option to work around this would be to parse both approaches and hope that one of them is present (as in #7244) - however in this instance we can instead introduce a State Migration to update the ID of the Resource - meaning that all EventHub Namespace Authorization Rules will have their Resource ID updated from the old (authorizationRules) to the new (AuthorizationRules).

Since State Migrations are a little involved, whilst I'd like to thank you for this contribution - I'm going to close this in favour of #7248 which adds that State Migration so that this can be consistently parsed as AuthorizationRules going forward, I hope you don't mind!

Thanks!

@ghost
Copy link

ghost commented Jul 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants