Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_api_management_api correctly wait for future on create/update #7273

Merged
merged 1 commit into from Jun 12, 2020
Merged

azurerm_api_management_api correctly wait for future on create/update #7273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 13 additions & 3 deletions azurerm/internal/services/apimanagement/api_management_api_resource.go
View file
Open in desktop
Expand Up @@ -273,9 +273,14 @@ func resourceArmApiManagementApiCreateUpdate(d *schema.ResourceData, meta interf
apiParams.APICreateOrUpdateProperties.APIVersionSetID = utils.String(versionSetId)
}

if _, err := client.CreateOrUpdate(ctx, resourceGroup, serviceName, apiId, apiParams, ""); err != nil {
future, err := client.CreateOrUpdate(ctx, resourceGroup, serviceName, apiId, apiParams, "")
if err != nil {
return fmt.Errorf("creating/updating API Management API %q (Resource Group %q): %+v", name, resourceGroup, err)
}

if err = future.WaitForCompletionRef(ctx, client.Client); err != nil {
return fmt.Errorf("waiting on creating/updating API Management API %q (Resource Group %q): %+v", name, resourceGroup, err)
}
}

description := d.Get("description").(string)
Expand Down Expand Up @@ -306,8 +311,13 @@ func resourceArmApiManagementApiCreateUpdate(d *schema.ResourceData, meta interf
params.APICreateOrUpdateProperties.APIVersionSetID = utils.String(versionSetId)
}

if _, err := client.CreateOrUpdate(ctx, resourceGroup, serviceName, apiId, params, ""); err != nil {
return fmt.Errorf("creating/updating API %q / Revision %q (API Management Service %q / Resource Group %q): %+v", name, revision, serviceName, resourceGroup, err)
future, err := client.CreateOrUpdate(ctx, resourceGroup, serviceName, apiId, params, "")
if err != nil {
return fmt.Errorf("creating/updating API Management API %q (Resource Group %q): %+v", name, resourceGroup, err)
}

if err = future.WaitForCompletionRef(ctx, client.Client); err != nil {
return fmt.Errorf("waiting on creating/updating API Management API %q (Resource Group %q): %+v", name, resourceGroup, err)
}

read, err := client.Get(ctx, resourceGroup, serviceName, apiId)
Expand Down