New data source azurerm_mssql_server and new block restorable_dropped_databases in azuerrm_mssql_server

[yupwei68]

Fix #6502
#7594

=== RUN TestAccAzureRMMsSqlDatabase_createRestoreMode
=== PAUSE TestAccAzureRMMsSqlDatabase_createRestoreMode
=== CONT TestAccAzureRMMsSqlDatabase_createRestoreMode
--- PASS: TestAccAzureRMMsSqlDatabase_createRestoreMode (2016.02s)

Sql server listing recoverableDatabases Api has problems, thus it's excluded in the PR: Azure/azure-rest-api-specs#10162

[katbyte]

Thanks for the PR @yupwei68 - i've left some comments inline that need to be addressed before merge

[yupwei68]

Hi @katbyte Thanks for your comments. I've replied the unchanged comments, others have been pushed. Please continue reviewing.

[yupwei68]

Hi @katbyte Thanks for your comments. Changes have been pushed. Please continue reviewing.

[yupwei68]

@katbyte Sorry for the mistakes. Please continue reviewing.

[jackofallops]

Hi @yupwei68
A couple of additional comments below. And apologies for re-opening the discussion on the property name, I'll try to catch up with @katbyte offline later today on that one.

Thanks

[katbyte]

@yupwei68 - as i have mentioned before, could we update the property names as suggested? thank you

[katbyte]

Couple more comments from a second pass

[yupwei68]

@katbyte @jackofallops Sorry for my previous misunderstandings. I have pushed the changes. Please continue reviewing.

[katbyte]

Thanks @yupwei68 - LGTM 👍

[ghost]

This has been released in version 2.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.29.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!