Fix some sql instance names to start with tf-test (#6933) (#13213)

Signed-off-by: Modular Magician <magic-modules@google.com> Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Dec 9, 2022 · 348619f · 348619f
1 parent 83f87df
commit 348619f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/.changelog/6933.txt b/.changelog/6933.txt
@@ -0,0 +1,2 @@
+```release-note:none
+```
diff --git a/google/data_source_sql_database_instance_test.go b/google/data_source_sql_database_instance_test.go
@@ -1,8 +1,9 @@
 package google
 
 import (
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 )
 
 func TestAccDataSourceSqlDatabaseInstance_basic(t *testing.T) {
@@ -36,7 +37,7 @@ func TestAccDataSourceSqlDatabaseInstance_basic(t *testing.T) {
 func testAccDataSourceSqlDatabaseInstance_basic(context map[string]interface{}) string {
 	return Nprintf(`
 resource "google_sql_database_instance" "main" {
-  name             = "main-instance-%{random_suffix}"
+  name             = "tf-test-instance-%{random_suffix}"
   database_version = "POSTGRES_11"
   region           = "us-central1"
 

diff --git a/google/resource_sql_user_test.go b/google/resource_sql_user_test.go
@@ -13,7 +13,7 @@ func TestAccSqlUser_mysql(t *testing.T) {
 	skipIfVcr(t)
 	t.Parallel()
 
-	instance := fmt.Sprintf("i-%d", randInt(t))
+	instance := fmt.Sprintf("tf-test-%d", randInt(t))
 	vcrTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
@@ -50,7 +50,7 @@ func TestAccSqlUser_iamUser(t *testing.T) {
 	skipIfVcr(t)
 	t.Parallel()
 
-	instance := fmt.Sprintf("i-%d", randInt(t))
+	instance := fmt.Sprintf("tf-test-%d", randInt(t))
 	vcrTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
@@ -75,7 +75,7 @@ func TestAccSqlUser_iamUser(t *testing.T) {
 func TestAccSqlUser_postgres(t *testing.T) {
 	t.Parallel()
 
-	instance := fmt.Sprintf("i-%d", randInt(t))
+	instance := fmt.Sprintf("tf-test-%d", randInt(t))
 	vcrTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
@@ -108,7 +108,7 @@ func TestAccSqlUser_postgres(t *testing.T) {
 func TestAccSqlUser_postgresIAM(t *testing.T) {
 	t.Parallel()
 
-	instance := fmt.Sprintf("i-%d", randInt(t))
+	instance := fmt.Sprintf("tf-test-%d", randInt(t))
 	vcrTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },
 		Providers:    testAccProviders,
@@ -134,7 +134,7 @@ func TestAccSqlUser_postgresIAM(t *testing.T) {
 func TestAccSqlUser_postgresAbandon(t *testing.T) {
 	t.Parallel()
 
-	instance := fmt.Sprintf("i-%d", randInt(t))
+	instance := fmt.Sprintf("tf-test-%d", randInt(t))
 	userName := "admin"
 	vcrTest(t, resource.TestCase{
 		PreCheck:     func() { testAccPreCheck(t) },