throw error if datasource not found (#6786) (#13070)

* throw error if datasource not found * update case Co-authored-by: Edward Sun <sunedward@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Signed-off-by: Modular Magician <magic-modules@google.com> Co-authored-by: Edward Sun <sunedward@google.com>
hashicorp · Nov 17, 2022 · 6c62647 · 6c62647
1 parent c2514e8
commit 6c62647
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/.changelog/6786.txt b/.changelog/6786.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+container: throw exception if the data source `google_container_cluster` does not exist
+```
diff --git a/google/data_source_google_container_cluster.go b/google/data_source_google_container_cluster.go
@@ -1,6 +1,8 @@
 package google
 
 import (
+	"fmt"
+
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
@@ -35,7 +37,17 @@ func datasourceContainerClusterRead(d *schema.ResourceData, meta interface{}) er
 		return err
 	}
 
-	d.SetId(containerClusterFullName(project, location, clusterName))
+	id := containerClusterFullName(project, location, clusterName)
+
+	d.SetId(id)
+
+	if err := resourceContainerClusterRead(d, meta); err != nil {
+		return err
+	}
+
+	if d.Id() == "" {
+		return fmt.Errorf("%s not found", id)
+	}
 
-	return resourceContainerClusterRead(d, meta)
+	return nil
 }