Skip to content

Commit

Permalink
make credit_types_treatment in google_billing_budget resource upd…
Browse files Browse the repository at this point in the history
…atable (#6763) (#12947)

Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
modular-magician committed Nov 4, 2022
1 parent 04da3a5 commit fc97fc0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .changelog/6763.txt
@@ -0,0 +1,3 @@
```release-note:bug
billingbudget: fixed a bug where `budget_filter.credit_types_treatment` in `google_billing_budget` resource was not updating.
```
3 changes: 2 additions & 1 deletion google/resource_billing_budget.go
Expand Up @@ -563,7 +563,8 @@ func resourceBillingBudgetUpdate(d *schema.ResourceData, meta interface{}) error
"budgetFilter.labels",
"budgetFilter.calendarPeriod",
"budgetFilter.customPeriod",
"budgetFilter.services")
"budgetFilter.services",
"budgetFilter.creditTypesTreatment")
}

if d.HasChange("amount") {
Expand Down
2 changes: 2 additions & 0 deletions google/resource_billing_budget_test.go
Expand Up @@ -147,6 +147,7 @@ resource "google_billing_budget" "budget" {
labels = {
label = "bar"
}
credit_types_treatment = "EXCLUDE_ALL_CREDITS"
}
amount {
Expand Down Expand Up @@ -241,6 +242,7 @@ resource "google_billing_budget" "budget" {
labels = {
label1 = "bar2"
}
credit_types_treatment = "INCLUDE_ALL_CREDITS"
services = ["services/24E6-581D-38E5"] # Bigquery
}
Expand Down

0 comments on commit fc97fc0

Please sign in to comment.