Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_bigquery_connection is missing Encryption / CMEK option #17955

Comments

@shashank-google
Copy link

shashank-google commented Apr 24, 2024

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

google_bigquery_connection when connecting to Cloud SQL has CMEK option in the UI (screenshot below)
image

New or Affected Resource(s)

  • google_bigquery_connection

Potential Terraform Configuration

resource "google_bigquery_connection" "connection" {
    connection_id = "my-connection"
    encryption_key_name  = google_kms_crypto_key.key.id
    location      = "US"
    friendly_name = "馃憢"
    description   = "a riveting description"
    cloud_sql {
        instance_id = google_sql_database_instance.instance.connection_name
        database    = google_sql_database.db.name
        type        = "POSTGRES"
        credential {
          username = google_sql_user.user.name
          password = google_sql_user.user.password
        }
    }
}

References

No response

b/337873927

@github-actions github-actions bot added forward/review In review; remove label to forward service/bigquery labels Apr 24, 2024
@daanheikens
Copy link

Looking at the API: https://cloud.google.com/bigquery/docs/reference/bigqueryconnection/rest/v1/projects.locations.connections#Connection

The field is available in the API, but i think we should name it: kms_key_name.

If agreed, i can pick this one up!

@rileykarson
Copy link
Collaborator

That seems reasonable! I'll assign you to mark you're taking a look.

@shashank-google
Copy link
Author

Many thanks for getting this fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment