Handle scheduler job state #11141
Open
Handle scheduler job state #11141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevenick
requested changes
Feb 22, 2022
There was a problem hiding this comment.
Unfortunately this resource is auto generated, so we won't be able to accept this patch.
Contributions for this resource can be added at https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/products/cloudscheduler/api.yaml but this is an unusual use case where custom code will be needed via a custom update or similar.
I'm a little worried about the implementation enabling jobs that users haven't specified that they want to enable. If a job was created via TF and paused manually we would enable via TF without telling the user what was going to happen
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new attribute
statethat can bePAUSEDorENABLEDAlso enables scheduler prior to any update, because a paused job cannot be updated
We should probably validate the
statevalue, but I'm not sure what the standard approach for this.