Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Vertex AI FeatureStore resources (GA only) #12797

Merged
merged 1 commit into from Oct 14, 2022
Merged

Promote Vertex AI FeatureStore resources (GA only) #12797

merged 1 commit into from Oct 14, 2022

Conversation

modular-magician
Copy link
Collaborator

part of #9298

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_vertex_ai_featurestore` (ga only)
`google_vertex_ai_featurestore_entitytype` (ga only)
`google_vertex_ai_featurestore_entitytype_feature` (ga only)

Derived from GoogleCloudPlatform/magic-modules#6565

@modular-magician
Promote Vertex AI FeatureStore resources (GA only) (hashicorp#6565)
f7c5480 
* feat: promote vertex ai feature store resources (ga only)

* feat: deprecate the field:       monitoring_interval

* Revert "feat: deprecate the field:       monitoring_interval"

This reverts commit 89d66724c71544ca544f2fb9f6d58471490aac0f.

* feat: update the example to use only the GA fields

* fix: diable monitoring_config.snapshot_analysis in the example

* feat: promote the featurestore entity feature resource to GA

* fix: add default_value to fix the unintentional diff

* feat: update the link to the api doc

* Revert "fix: add default_value to fix the unintentional diff"

This reverts commit d3b509033e2a8c3f5ed239867daa4623859dcf42.

* refactor: use deprecation_message to clarify the deprecated field

* feat: add a new example to test beta fields

* fix: use a different resource name to run tests in parallel

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 10abd3e into hashicorp:main Oct 14, 2022
@SarahFrench SarahFrench mentioned this pull request Oct 31, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@modular-magician