Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Resource Cryptokeyversions #12926

Merged
merged 1 commit into from Nov 1, 2022
Merged

Add new Resource Cryptokeyversions #12926

merged 1 commit into from Nov 1, 2022

Conversation

modular-magician
Copy link
Collaborator

Add new resource cryptoKeyVersions

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

kms: Add new resource CryptoKeyVersions

Derived from GoogleCloudPlatform/magic-modules#6553

@modular-magician
Add new Resource Cryptokeyversions (hashicorp#6553)
f14bb8b 
* Add new resource cryptokeyVersion, and the tests.

* Resource cryptoKeyVersion -- Fix errors that prevent creation

* CryptoKeyVersion resource -- [WIP] commit

* CryptoKeyVersions -- Fix tests for create and create with skip_initial_version

* CryptoKeyVersions -- Fix after running gofmt

* CryptoKeyVersions -- modification based on PR feedback, except add update test

* CryptoKeyVersion -- Add update test

* gofmt fix the test file

* Remove unused fields and update tests

* Add custom import, yet tests aren't fully passing because of custom_delete

* Attempt to fix custom import and delete

* Delete kms_crypto_key_version.erb

* Fix Custom delete issues

* Enable importStateVerify to all tests

* Fix make lint problem

* Delete go.mod

* (1) Remove enum values for output fields
(2) fix indentation problems
(3) Fix state verify for crypto_Key
(4) Add remove test for cryptoKeyVersions
(5) WIP Fix custom_delete issues

* (1) Call destroy at cryptoKeyVersion deletion
(2) Do not destroy cryptoKeyVersion when deleting crypto_key

* CryptoKeyVersions Delete, put error handler first

* Uncomment clearCryptoKeyVersions when deleting cryptoKey

* Align with master branch, check for state before deleting cryptokeyversion

* Remove state check in cryptoKeyVersions deletion

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e394fdd into hashicorp:main Nov 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@modular-magician