Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firebase Hosting site Terraform provider #12960

Merged
merged 1 commit into from Nov 7, 2022
Merged

Firebase Hosting site Terraform provider #12960

merged 1 commit into from Nov 7, 2022

Conversation

modular-magician
Copy link
Collaborator

Adds provider support for Firebase Hosting Sites API, along with handwritten update test

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
`google_firebase_hosting_site`

Derived from GoogleCloudPlatform/magic-modules#6598

@modular-magician
Firebase Hosting site Terraform provider (hashicorp#6598)
a8b8f82 
* Firebase Hosting site Terraform provider

* Add sweeper to Firebase Hosting Site

* Add a basic hosting site without app

* Move app_id to test_vars_overrides to avoid adding random_suffix

* Add defaultUrl. Shorten base_url. Add sites/site-id import

* Create new web app as part of hosting site test

* Fix tab vs spaces

* Separate basic and full test for firebasehosting

* Add update test for google_firebase_hosting_site

* Use immediate delete for test web app

* Use deletion_policy = DELETE for handwritten update test

* Address feedack on site_id name

* Use specific Firebase Hosting docs

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit a03efd4 into hashicorp:main Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@modular-magician