Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the dcl version to v1.26.0 #12965

Conversation

modular-magician
Copy link
Collaborator

Upgrade the dcl version to v1.26.0
The reason for this upgrade is to add new fields to the DeliveryPipeline and Target resources.
A fix for #12714 is also included.

If this PR is for Terraform, I acknowledge that I have:

  • [ x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

clouddeploy: Added support for Cloud Run Targets (beta)
clouddeploy: Added support for Deployment Verification standard strategy (beta)
clouddeploy: Added execution_configs.execution_timeout in target resource. (beta)
compute: machine_type field in compute instance resource now accepts short name.
orgpolicy: Changed spec.rules type from Array to Set in policy resource.
https://github.com/hashicorp/terraform-provider-google/issues/12363

Derived from GoogleCloudPlatform/magic-modules#6639

* Upgrade DCL to v1.23.0

* add clouddeploy test files

* upgrade dcl to v1.25

* upgrade dcl to v1.26

* delete extra samples folder. test executionTimeout field in run target json

* add tags, and monitoring_config

* Add monitoringConfig to other files

* Add a test for GKEHub servicemesh and exclude Eventarc trigger channel field

* remove monitoring_config in handwritten tests and adding exclude for field in beta

Co-authored-by: Chris Hawk <hawk@google.com>
Co-authored-by: Ghaleb Al-habian <galhabian@google.com>
Co-authored-by: ghabian <ghabian@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 81a1e16 into hashicorp:main Nov 7, 2022
megan07 added a commit that referenced this pull request Nov 11, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant