Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BigQuery authorized routines #12979

Conversation

modular-magician
Copy link
Collaborator

Add support for authorized routines on BigQuery.

Fixes #11501 .

I just tested to assign some routines as an authorized routines to some datasets using local built provider.
But I can not run acceptance tests.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: supported authorized routines on resource `bigquery_dataset` and `bigquery_dataset_access`

Derived from GoogleCloudPlatform/magic-modules#6680

* BigQuery: Added support for authorized routine

* BigQuery: Added examples for authorized routine

* Update mmv1/products/bigquery/terraform.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/templates/terraform/examples/bigquery_dataset_authorized_routine.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* add legacy iam access to test case

* remove legacy roles

* correct variable names and values

* replace - to _

* [wip]added hand written test

* fix corrupted test

* Update mmv1/third_party/terraform/tests/resource_bigquery_dataset_access_test.go

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 12d406e into hashicorp:main Nov 8, 2022
megan07 added a commit that referenced this pull request Nov 11, 2022
megan07 added a commit that referenced this pull request Nov 11, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support BigQuery authorized routines
1 participant