Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix google_app_engine_flexible_app_version.service_account permadiff #12982

Merged
merged 1 commit into from Nov 8, 2022
Merged

Fix google_app_engine_flexible_app_version.service_account permadiff #12982

merged 1 commit into from Nov 8, 2022

Conversation

modular-magician
Copy link
Collaborator

Fixes #12527

Adds default_from_api:true to ServiceAccount under FlexibleAppVerison in AppEngine terraform.yaml to resolve permadiff.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

appengine: Fixed permadiff on serviceaccount for 'google_app_engine_flexible_app_version'

Derived from GoogleCloudPlatform/magic-modules#6747

@modular-magician
Fix google_app_engine_flexible_app_version.service_account permadiff (h…
90c4b39 
…ashicorp#6747)

* Update compute_security_policy documentation for type field

Documentation updated for the type field to be in sync with the API docs located at https://cloud.google.com/compute/docs/reference/rest/v1/securityPolicies

* Update compute_security_policy documentation for type field

Documentation updated for the 'type' field to be in sync with the API docs located at https://cloud.google.com/compute/docs/reference/rest/v1/securityPolicies

* Add default_from_api:true flag to serviceAccount under FlexibleAppVersion in AppEngine

* Add default_from_api:true flag to serviceAccount under FlexibleAppVersion in AppEngine

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e02e98c into hashicorp:main Nov 8, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test(s): google_app_engine_flexible_app_version.service_account (permadiff)
1 participant
@modular-magician