Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields for specifying GKE logging variant at the cluster-wide and node pool level. #13049

Commits on Nov 16, 2022

  1. Add a logging_variant field to GKE node pools and to node pool defa…

    …ults for GKE clusters. (hashicorp#6744)
    
    This PR implements the feature request from [Add GKE logging variant field for increasing log agent throughput hashicorp#12667](hashicorp#12667).
    
    By adding a logging_variant field within the node_pool_defaults, GKE users will be able to select a cluster-wide default value for the logging agent of the node pools in a cluster. For example, by specifying
    ```terraform
    resource "google_container_cluster" "with_logging_variant_node_pool_default" {
      name               = "example-cluster"
      location           = "us-central1-f"
      initial_node_count = 1
    
      node_pool_defaults {
        node_config_defaults {
          logging_variant = "MAX_THROUGHPUT"
        }
      }
    }
    ```
    every newly created node pool in the cluster will have the max throughput logging agent unless this is explicitly overridden at the node pool level (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information).
    
    GKE users will also be able to select a logging variant at the node pool level. For example, by specifying
    ```terraform
    resource "google_container_cluster" "with_logging_variant_node_pool_default" {
      name               = "example-cluster"
      location           = "us-central1-f"
      initial_node_count = 1
    
      node_pool_defaults {
        node_config_defaults {
          logging_variant = "DEFAULT"
        }
      }
    }
    resource "google_container_node_pool" "with_high_throughput_logging_variant" {
      name    = "example-node-pool-0"
      cluster = google_container_cluster.with_logging_variant_node_pool_default.name
    }
    resource "google_container_node_pool" "with_high_throughput_logging_variant" {
      name    = "example-node-pool-1"
      cluster = google_container_cluster.with_logging_variant_node_pool_default.name
      node_config {
        logging_variant = "MAX_THROUGHPUT"
      }
    }
    ```
    example-node-pool-0 (as well as the default node pool) will have the default logging agent (see the [GKE docs](https://cloud.google.com/stackdriver/docs/solutions/gke/managing-logs#high_throughput_for_all_nodes_in_a_cluster) for more information), but example-node-pool-1 will have the max throughput agent.
    
    Signed-off-by: Modular Magician <magic-modules@google.com>
    modular-magician committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    e6ba641 View commit details
    Browse the repository at this point in the history