Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute: Add support for IGM/RIGM list_managed_instances_results field. #13079

Conversation

modular-magician
Copy link
Collaborator

This PR adds a support for recently added list_managed_instances_results field to compute_instance_group_manager and compute_region_instance_group_manager resources.

Upgrade of google.golang.org/api to version v0.102.0 was required for the GA availability.

Testing disclaimer: I had some trouble with acceptance tests, which were all failing with error:

provider_test.go:307: Failed state verification, resource with ID projects/debian-cloud/global/images/debian-11-bullseye-v20221102 not found

All the tests are passing with ImportStateVerify set to false, but I wasn't able to get the state verification to work.


If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `list_managed_instances_results` to `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager`

Derived from GoogleCloudPlatform/magic-modules#6787

…d. (hashicorp#6787)

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 85eb4f6 into hashicorp:main Nov 18, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant