Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertexai): add google_vertex_ai_index for Vertex AI Matching Engine #13132

Conversation

modular-magician
Copy link
Collaborator

Part of #12818
Part of #9298

Add google_vertex_ai_index to create an index for Vertex AI Matching Engine.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_vertex_ai_index

Derived from GoogleCloudPlatform/magic-modules#6728

…ine (hashicorp#6728)

* feat: add google_vertex_ai_index for Vertex AI Matching Engine

* fix: increase timeouts to 60 min because 20 wasn't enough for creation

* fix: change coe to make name computed instead of an input

* fix: use costom flatten code to ignore_read a nested property's field

* fix: add skip_import_test: true to the auto-gen test

* feat: add a test with a manually updated ImportStateVerifyIgnore

* Apply suggestions from code review [ci skip]

Update descriptions based on the suggestions

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* refactor: use ignore_read_extra instead of a manual test

* fix: use an empty object for bruteForceConfig

* feat: define additional fields to api.yaml

* feat: add an example to increase test coverage

* feat: deal with contentsDeltaUri as an updatable field

* fix: fix the error because the cosine distance type only supports unit l2 norm type

This is the error message from the endpoint:
"Index with `COSINE_DISTANCE` distanceMeasureType currently only supports `UNIT_L2_NORM` featureNormType."

* feat: remove approximate_neighbors_count from an example with brute_force_config

approximate_neighbors_count is required if tree-AH algorithm is used.
from https://cloud.google.com/vertex-ai/docs/matching-engine/configuring-indexes#brute-force-config

* test: add a handwritten test for patch

* fix: add update_mask: true to use the mask as a url param

* refactor: put 'input: true' on the fields patch couldn't update

* feat: use custom pre update code for a nested object

* fix: update the handwritten test accordingly

* feat: add custom flatten code for is_complete_overwrite

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit ef90752 into hashicorp:main Nov 29, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant