Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastream check private connection state after create and update #13160

Conversation

modular-magician
Copy link
Collaborator

Datastream Private Connection resources create operation can finish successfully when the actual resource fails.

To solve that in TF, we will add a custom post create code (this only happens in create) that will verify the resource state after creation.

datastream: fixed `google_datastream_private_connection` ignoring failures during creation

Derived from GoogleCloudPlatform/magic-modules#6862

…shicorp#6862)

* Add desired state field to make sure PC is created in CREATED - b/260057913

* Revert virtual field

* Add state field check to make sure PC is created in CREATED - b/260057913

* Add error details and message in failure cases.

* Fix message formatting

* Added a post import impl

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 53295dc into hashicorp:main Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant