Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made google_document_ai_processor_default_version test ignore changes to version field #13781

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

modular-magician
Copy link
Collaborator

Resolved #12905 by altering the test to ignore changes (and improving documentation.)

projectNumberDiffSuppress is already in place to handle diffs based solely on the project id -> project number change; the larger issue is that the API replaces release channels (now called "stable" and "rc") with specific API versions. Unfortunately, this API does not supply a way to extract the list of versions in a particular release channel, so there's no way to make a data source to get the "latest stable version" and have the resource use that. Fully suppressing the diff in the provider would mislead users into thinking that they are on the latest stable or rc release, when in fact they might be extremely out of date.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#7317

… to version field (hashicorp#7317)

* Fixed permadiff for channel-based processor versions

* Removed update functionality and updated tests & docs to use ignore_changes

* Tweaked docs example

* Removed update settings

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Feb 17, 2023
… to version field (hashicorp#7317) (hashicorp#13781)

* Fixed permadiff for channel-based processor versions

* Removed update functionality and updated tests & docs to use ignore_changes

* Tweaked docs example

* Removed update settings

Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): ForceNew permadiff: TestAccDocumentAIProcessorDefaultVersion_documentaiDefaultVersionExample
1 participant