Don't fail plan if project,region,zone defaults cannot be retrieved #16135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DefaultProviderProject, DefaultProviderRegion and DefaultProviderZone funcs set respectively the project, region and zone in a diff if one is provided, unless they fetch the defaults from config. However, at times, these value may not be available during a plan, as they are dynamically computed at apply time. We should avoid throwing an error if this is the case, but rather set an empty value in the diff. Resolves hashicorp#16133
|
** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DefaultProviderProject, DefaultProviderRegion and DefaultProviderZone funcs set respectively the project, region and zone in a diff if one is provided, unless they fetch the defaults from config. However, at times, these values may not be available during a plan, as they are dynamically computed at apply time.
We should avoid throwing an error if this is the case, but rather set an empty value in the diff.
Resolves #16133