Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS_config_first_commit #16945

Conversation

modular-magician
Copy link
Collaborator

Fixes - #16355

This PR is to support provisioning kmsConfigs for Google Cloud NetApp Volumes through GCP terraform provider.

`google_netapp_kmsconfig`

Derived from GoogleCloudPlatform/magic-modules#9353

* KMS_config_first_commit

* kmscommit for author change

* Updated label to KeyValueLabels

* kmsconfig_update_key_ring_crypto_key_name

* Fixed issues in resource_netapp_kmsconfig_test.go

* removed roation_period

* changed location to us-west1

* fixed double quotes

* changes_with_labels

* changed location to us-central1
[upstream:08644b8fb4c5d63b13c11283a068f1e132903637]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 150705d into hashicorp:main Jan 9, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant