TeamCity: test utils refactor #18113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:998f8f9a5f175b77363c9a22020f032b919eb391] Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Test utils:
Previously there was a
getSubProjectfunction that would retrieve a project that was nested 2 levels deep from a starting project. It was always given the root of the TeamCity project and was used to pull out projects from within the Google or Google Beta projects.Now,
getSubProjectdoes something more logical given its name. You supply aProjectand the name of a subproject within it, and it'll return aProjectobject for that subproject. This can be used to make assertions on, etc.The original functionality of retrieving a project from 2 levels of nesting is now fulfilled by
getNestedProjectFromRoot, which uses getSubProject internally.This PR refactors existing acceptance tests to use the new test utils.
Error message framing
Messages needed to be rewritten to be pointing out why a given test would fail.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10290