Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ReadContext with ReadWithoutTimeout #389

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Replace ReadContext with ReadWithoutTimeout #389

merged 4 commits into from
Sep 9, 2022

Conversation

itsjaspermilan
Copy link
Contributor

@itsjaspermilan itsjaspermilan commented Sep 8, 2022 •
edited

🛠️ Description

Temporary fix to address an issue where timeouts aren't applied to a Data Source read. Relates to hashicorp/terraform-plugin-sdk#1038

🚢 Release Note

Release note for CHANGELOG:

* {azure data source}: {Replace ReadContext with ReadWithoutTimeout in the Azure and AWS peering connection} [GH-389]

🏗️ Acceptance tests

  • Are there any feature flags that are required to use this functionality?
  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Paras Prajapati and others added 4 commits September 8, 2022 13:56
@bcmdarroch
Copy link
Contributor

bcmdarroch commented Sep 9, 2022 •
edited

Acceptance tests passing!

--- PASS: TestAccAzurePeeringConnection (1192.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	1193.304s

--- PASS: TestAccAwsPeering (713.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-hcp/internal/provider	717.061s

@itsjaspermilan itsjaspermilan marked this pull request as ready for review September 9, 2022 14:39
@itsjaspermilan itsjaspermilan requested a review from a team as a code owner September 9, 2022 14:39
@itsjaspermilan itsjaspermilan requested a review from a team September 9, 2022 14:39
@itsjaspermilan itsjaspermilan merged commit 8e14446 into main Sep 9, 2022
@itsjaspermilan itsjaspermilan deleted the hce-bug-timeouts-not-applied branch September 9, 2022 18:37
@bcmdarroch bcmdarroch mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcmdarroch bcmdarroch bcmdarroch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itsjaspermilan @bcmdarroch