Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) CRLF bug in values.yaml reading; view Issue #543 #1007

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(fix) CRLF bug in values.yaml reading; view Issue #543 #1007

wants to merge 1 commit into from
+6 −0

Conversation

EttoreFoti
Copy link

@EttoreFoti EttoreFoti commented Dec 9, 2022 •
edited

Description

This few lines should be enough to fix the linked issue by ignoring any CRLF character that causes changes inside values.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

NONE

References

#543

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@EttoreFoti EttoreFoti requested a review from a team as a code owner December 9, 2022 15:46
@hashicorp-cla
Copy link

hashicorp-cla commented Dec 9, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the stale label Dec 10, 2023
@github-actions github-actions bot closed this Jan 9, 2024
@BBBmau BBBmau reopened this Jan 9, 2024
@github-actions github-actions bot removed the stale label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EttoreFoti @hashicorp-cla @BBBmau