Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Helm lookup in manifest experiment #1335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omgftw
Copy link

@omgftw omgftw commented Feb 23, 2024

Description

This fix is for the "manifest" experiment.

Some charts (notably aws-load-balancer-controller) depend on Helm's lookup function to get data from certain resources. Often if they cannot get this data, they will generate new data (ex: a UUID). In this case, this will cause a permanent diff and you will not be able to upgrade the chart, since the plan will always change, resulting in a "Provider produced inconsistent final plan" error.

To resolve this, I set the "DryRunOption" to "server". According to Helm's docs:

Setting --dry-run==server will additionally execute any lookup in your chart towards the server.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
    ^ No, but I have tested the change manually.

Release Note

Release note for CHANGELOG:

NONE

References

#805
#711

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@omgftw omgftw requested a review from a team as a code owner February 23, 2024 08:20
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 23, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants