Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Helm DeletionPropagation in Uninstall #1365

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adrianmace
Copy link

Description

This PR aims to fix #1363

By passing through the DeletionPropagation value down to the Helm library, we can support the foreground cascading deletion feature of Kubernetes.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

TODO

Release Note

Release note for CHANGELOG:

`helm_release`: Add `deletion_propagation` property to control Kubernetes Cascading Deletion behaviour.

References

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Copy link

hashicorp-cla-app bot commented May 10, 2024

CLA assistant check
All committers have signed the CLA.

@adrianmace
Copy link
Author

Due to my limited knowledge of Golang and the way in which this codebase is structured/tested, I'd be happy to hand this PR over in this state to a maintainer to complete and release the work.

The only elements I was unsure about is test coverage (if required) and if the Schema version needs to be updated due to this additional field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DeletionPropagation in Uninstall
1 participant