Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace_selector to pod's affinities #2020

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

artemvang
Copy link

@artemvang artemvang commented Feb 27, 2023

Description

This change adds new attribute namespace_selector to the kubernetes_pod resource (affinities section).
See #1826.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 27, 2023

CLA assistant check
All committers have signed the CLA.

@artemvang artemvang changed the title Add namespace_selector to pod's affinities definition Add namespace_selector to pod's affinities Feb 27, 2023
@github-actions github-actions bot added size/M and removed size/S labels Feb 27, 2023
@artemvang artemvang marked this pull request as ready for review February 27, 2023 14:40
@artemvang artemvang requested a review from a team as a code owner February 27, 2023 14:40
@BBBmau
Copy link
Contributor

BBBmau commented May 10, 2023

Hello! Thank you for opening this PR @artemvang. Could you also add some tests for the namespace_selector attribute as well?

@Nox-404
Copy link

Nox-404 commented Dec 21, 2023

Hello,
any update on this ?

@BBBmau
Copy link
Contributor

BBBmau commented Dec 21, 2023

@artemvang pinging to know if you're still interested in contributing with this PR. It would be a great addition. Only thing missing is a test that checks for the namespace_selector attribute. You can reference how other attributes are checked within other resources in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants