Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Contribution Guide #2397

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Updating Contribution Guide #2397

wants to merge 5 commits into from

Conversation

sheneska
Copy link
Contributor

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@appilon
Copy link
Contributor

appilon commented Jan 22, 2024

Wanted to add a quirk I noticed, while using Docker Desktop on Mac, despite /Users/ being added to file sharing by default, the seccomp profile needed during a few tests located in ./.github/config/seccomp-profiles does not appear to be accessible during the tests.

Very oddly, adding the mount destination folder to the file sharing settings in Docker Desktop (you have to type it out and hit enter, clicking the + icon will open Finder for your to choose a local directory), fixes the issue. I can't explain why adding where the folder gets mounted to within containers matters at all 🤷‍♂️.

May want to make special note of this in the guide if the seccomp local profile tests fail. I suspect some kind of bug in Docker Desktop or perhaps default file/folder permissions of a github repo are in conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants