Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JobBackoffLimitPerIndex feature gate fields #2421

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

theloneexplorerquest
Copy link

@theloneexplorerquest theloneexplorerquest commented Feb 10, 2024

Description

resolve #2398

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@alexsomesan
Copy link
Member

Thanks a lot for the contribution, @theloneexplorerquest

We have a long standing policy of not including features still behind feature gates, because there is no mechanism available on the Kubernetes API for the provider to query whether the feature gate is on or off and it would lead to unexpected errors on clusters that don't have the feature on.

As I mentioned, we appreciate the contribution and would love to merge this once the feature becomes universally available. Please feel free to keep the PR up to date going forward.

Thanks!

@theloneexplorerquest
Copy link
Author

Hi @alexsomesan ,

Thanks for the update, I will keep this open and wait until this feature become universally available (and do more testing at that time!).

@theloneexplorerquest theloneexplorerquest marked this pull request as ready for review March 7, 2024 10:36
@theloneexplorerquest theloneexplorerquest requested a review from a team as a code owner March 7, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support JobBackoffLimitPerIndex feature gate fields
2 participants