Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Template Files - TFPluginDocs #2477

Merged
merged 23 commits into from
May 22, 2024
Merged

Edit Template Files - TFPluginDocs #2477

merged 23 commits into from
May 22, 2024

Conversation

sheneska
Copy link
Contributor

Description

This PR adds data fields, where appropriate to the template files for runtime class and namespace resources.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@sheneska sheneska requested a review from a team as a code owner April 25, 2024 17:22
@sheneska sheneska changed the title Edit namespace and runtime class resource files Edit Template Files - TFPluginDocs Apr 29, 2024
Copy link

@jastr945 jastr945 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the changes, although i don't have much context, the updates made sense to me.

sheneska and others added 6 commits April 30, 2024 17:17
* Edit resource template files

* fix checkers-and linters
* Edit resource template files

* Edit template files
* Edit resource template files

* Edit template files

* Edit resource files

* fix validation check
* Edit resource template files

* Edit template files

* Edit resource files

* fix validation check

* Edit resource files - batch 4

* Edit resource templates - batch 4
* Edit resource template files

* Edit template files

* Edit resource files

* fix validation check

* Edit resource files - batch 4

* Edit resource templates - batch 4

* Edit resource files - batch 5
@@ -9,6 +9,67 @@ description: |-

An API Service is an abstraction which defines for locating and communicating with servers.

<!-- schema generated by tfplugindocs -->
## Schema
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This autogenerated schema section is now duplicating the information in the argument reference below 鈥撀爏o I think you'll need to remove all those sections.

@sheneska sheneska merged commit 72041db into main May 22, 2024
17 checks passed
@sheneska sheneska deleted the edit-namespace-runtimeclass branch May 22, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants