Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ed25519 on the PKI backend also for intermediate_cert_request #1278

Merged
merged 1 commit into from Jan 5, 2022
Merged

Allow ed25519 on the PKI backend also for intermediate_cert_request #1278

merged 1 commit into from Jan 5, 2022

Conversation

fhilgers
Copy link
Contributor

@fhilgers fhilgers commented Jan 3, 2022

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates hashicorp/vault#11780 and #1185

Release note for CHANGELOG:

Allow Ed25519 on the PKI backend also for intermediate_cert_request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 3, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@benashz benashz added this to the 3.2.0 milestone Jan 5, 2022
@benashz benashz self-requested a review January 5, 2022 22:18
benashz
benashz approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for your contribution to HashiCorp!

@benashz benashz merged commit 2d666af into hashicorp:main Jan 5, 2022
benashz added a commit that referenced this pull request Jan 5, 2022
@benashz
Update changelog for #1278
d8a29b3
@benashz benashz mentioned this pull request Jan 5, 2022
Merged
benashz added a commit that referenced this pull request Jan 5, 2022
@benashz
Update changelog for #1278
94063e4
benashz added a commit that referenced this pull request Jan 5, 2022
@benashz
Update changelog for #1278
75cbedf
benashz added a commit that referenced this pull request Jan 5, 2022
@benashz
Update changelog for #1278 (#1282)
46e2bd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fhilgers @hashicorp-cla @benashz